fix(plan-mode): deliver approval as follow-up after compact approval #66

Merged

lucas merged 1 commit from agent/issue-38-compact-approval into main

2026-10-26 12:14:00 +01:00

omp-deck commented

2026-10-26 12:02:46 +01:00

Collaborator

Closes: #38

PlanModeSessionSurface.compact now accepts { suppressContinuation }.
New #compactForExecution helper compacts with suppressContinuation: true (best-effort, logs on failure); used by both the live and detached approve paths.
Live compact path queues the approval text as a non-awaited synthetic followUp prompt after compaction; the tool result still carries the approval. keep mode is unchanged.
Tests: compact options, compact→prompt ordering, extra instructions, compaction-failure case, detached suppressContinuation.

Verified: bun test src/bridge/plan-mode-bridge.test.ts (24 pass), tsc --noEmit clean. Manual UI check from the issue not performed (unattended session). If it shows a duplicate execute instruction (meaning compaction didn't abort the turn), apply the fallback from the issue's contingency section.

Closes: #38 - `PlanModeSessionSurface.compact` now accepts `{ suppressContinuation }`. - New `#compactForExecution` helper compacts with `suppressContinuation: true` (best-effort, logs on failure); used by both the live and detached approve paths. - Live compact path queues the approval text as a non-awaited synthetic `followUp` prompt after compaction; the tool result still carries the approval. `keep` mode is unchanged. - Tests: compact options, compact→prompt ordering, extra instructions, compaction-failure case, detached `suppressContinuation`. Verified: `bun test src/bridge/plan-mode-bridge.test.ts` (24 pass), `tsc --noEmit` clean. Manual UI check from the issue not performed (unattended session). If it shows a duplicate execute instruction (meaning compaction didn't abort the turn), apply the fallback from the issue's contingency section.

omp-deck added 1 commit

2026-10-26 12:02:47 +01:00

fix(plan-mode): deliver approval as follow-up after compact approval f3012c7834

Manual compaction aborts the in-flight propose turn, so the approval tool
result never reached the model and the SDK resumed with a generic nudge.
Compact with suppressContinuation and queue the approval text as a
synthetic follow-up prompt in both live and detached paths.

Co-Authored-By: Claude Opus 5.5 via omp-deck