fix(server): restore removal of the progress label after a merge #261

Merged

lucas merged 1 commit from agent/issue-256-clear-progress-label into main

2026-11-11 11:19:53 +01:00

omp-deck commented

2026-11-11 11:06:44 +01:00

Collaborator

clearProgressLabel called this.swapLabels, which #249 replaced with the free function applyLabelDelta while #250 added the new call site. The merge of both took the call site without the method.

Switched to applyLabelDelta(api, { owner, repo, number }, { remove: [progressLabel] }) — same semantics, array arguments.

Beyond the typecheck error this was a live bug: the TypeError was swallowed by clearProgressLabel's own try/catch, so a merged implementation silently kept its progress label.

Verified locally: bun run typecheck clean across all packages; bun test in apps/server 1305 pass / 0 fail, including a merged implementation loses the progress label of its issue, which was failing on main.

Closes: #256

`clearProgressLabel` called `this.swapLabels`, which #249 replaced with the free function `applyLabelDelta` while #250 added the new call site. The merge of both took the call site without the method. Switched to `applyLabelDelta(api, { owner, repo, number }, { remove: [progressLabel] })` — same semantics, array arguments. Beyond the typecheck error this was a live bug: the `TypeError` was swallowed by `clearProgressLabel`'s own `try`/`catch`, so a merged implementation silently kept its progress label. Verified locally: `bun run typecheck` clean across all packages; `bun test` in `apps/server` 1305 pass / 0 fail, including `a merged implementation loses the progress label of its issue`, which was failing on `main`. Closes: #256

omp-deck added 1 commit

2026-11-11 11:06:44 +01:00

fix(server): restore removal of the progress label after a merge 96febe44ab

`clearProgressLabel` still called the `swapLabels` helper that was
replaced by the free function `applyLabelDelta`. The semantic merge of
the two branches left `main` red on typecheck, and at runtime the
`TypeError` was swallowed by the surrounding `catch`, so a merged
implementation kept its progress label.

Co-Authored-By: Claude Opus 5 via omp-deck