bitsquid_dt/dtmt
bitsquid_dt/dtmt
2
Fork 0
Code Issues 34 Pull requests 11 Projects 1 Releases 3 Packages 1 Wiki Activity
Var Dump: 
dumpVar: only available in dev mode
Mailing List

Indicate when a deployment is necessary #49

Merged
lucas merged 3 commits from issue/32 into master 2023-03-06 16:04:25 +01:00
Conversation 1 Commits 3 Files changed 9 +106 -80
lucas commented 2023-03-03 17:05:08 +01:00
Owner
Copy link
No description provided.
lucas added this to the DTMM v1.0 + DTMT milestone 2023-03-03 17:05:08 +01:00
lucas added 2 commits 2023-03-03 17:05:09 +01:00 
Closes #32.
lucas commented 2023-03-03 17:08:31 +01:00
Author
Owner
Copy link

The indicator does show up for things like changing mod order, but not when enabling or disabling mods.

It looks like druid::Data does not compare into the nested values by default, and access into immutable structures like im::Vector is still mutable to some extend. I guess I must have missed that for the settings save trigger.

I'll have to check if im has a way to make a struct immutable. Otherwise, I'll have to create more controllers, which can check the various fields and data bits I need.

The indicator does show up for things like changing mod order, but not when enabling or disabling mods. It looks like `druid::Data` does not compare into the nested values by default, and access into immutable structures like `im::Vector` is still mutable to some extend. I guess I must have missed that for the settings save trigger. I'll have to check if `im` has a way to make a struct immutable. Otherwise, I'll have to create more controllers, which can check the various fields and data bits I need.
lucas changed title from Indicate when a deployment is necessary to WIP: Indicate when a deployment is necessary 2023-03-06 09:29:53 +01:00
lucas added 1 commit 2023-03-06 16:03:40 +01:00
lucas changed title from WIP: Indicate when a deployment is necessary to Indicate when a deployment is necessary 2023-03-06 16:03:55 +01:00
lucas merged commit f021e507b8 into master 2023-03-06 16:04:25 +01:00
lucas deleted branch issue/32 2023-03-06 16:04:25 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ci

   
crate/dtmm

   
crate/dtmt

   
crate/sdk

   
crate/serde_sjson
  
kind
bug
Something is not working

  
kind
documentation
Documentation needs to be adjusted

  
kind
enhancement
Improvement of existing functionality

  
kind
feature
New behaviour or functionality

  
kind
question
More information is needed

  
kind
upstream
This needs to be addressed in the dependency that causes it

  
part/bundle

   
part/filetype
  
stage
actionable

  
stage
design

  
stage
proposal

  
status/duplicate

This issue or pull request already exists

  
status/good first issue

Simple and/or isolated changes that can serve as an introduction to the code base

  
status/help wanted

   
status/invalid

Something is wrong

  
status
need-replicate
Additional information required to replicate the issue for debuggin

  
status/wontfix

This won't be fixed

No labels
ci
crate/dtmm
crate/dtmt
crate/sdk
crate/serde_sjson
kind
bug
kind
documentation
kind
enhancement
kind
feature
kind
question
kind
upstream
part/bundle
part/filetype
stage
actionable
stage
design
stage
proposal
status/duplicate
status/good first issue
status/help wanted
status/invalid
status
need-replicate
status/wontfix
Milestone
Clear milestone
No items
No milestone
DTMM v1.0 + DTMT
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: bitsquid_dt/dtmt#49
No description provided.
Delete branch "issue/32"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?