bitsquid_dt/dtmt
bitsquid_dt/dtmt
2
Fork 0
Code Issues 35 Pull requests 9 Projects 1 Releases 3 Packages 1 Wiki Activity Actions

Handle NXM URIs #150

Merged
lucas merged 3 commits from feat/nexus-uri-handler into master 2023-12-01 09:22:09 +01:00
Conversation 3 Commits 3 Files changed 11 +296 -43
lucas commented 2023-11-27 15:36:11 +01:00
Owner
Copy link
No description provided.
Fetch file version from Nexus
All checks were successful
lint/clippy Checking for common mistakes and opportunities for code improvement
build/msvc Build for the target platform: msvc
build/linux Build for the target platform: linux
246564d00f
 
When importing an archive file downloaded from Nexus, the file name does
include a version field. But, presumably for compatibility reasons,
Nexus replaces special characters with `-`, so that this field doesn't
match common schemes like `1.0.0`.
So instead we use the also included update timestamp to find the
corresponding file info from Nexus and use the version data from that.

Closes #131.
lucas force-pushed feat/nexus-uri-handler from 5994fc5041
Some checks failed
lint/clippy Checking for common mistakes and opportunities for code improvement
build/msvc Build for the target platform: msvc
build/linux Build for the target platform: linux
to 5b798473d4
Some checks failed
build/msvc Build for the target platform: msvc
lint/clippy Checking for common mistakes and opportunities for code improvement
build/linux Build for the target platform: linux
2023-11-27 15:42:35 +01:00 Compare
lucas commented 2023-11-28 23:38:23 +01:00
Author
Owner
Copy link

Building NNG fails because the cc and cmake crates cannot properly detect MSVC cross-platform builds by themselves.

error: failed to run custom build command for `nng-sys v1.4.0-rc.0`

Caused by:
  process didn't exit successfully: `/tmp/build/80754af9/repo/target/release/build/nng-sys-2712530b7f2d6bdf/build-script-build` (exit status: 101)
  --- stdout
  cargo:rustc-cfg=try_from
  CMAKE_TOOLCHAIN_FILE_x86_64-pc-windows-msvc = None
  CMAKE_TOOLCHAIN_FILE_x86_64_pc_windows_msvc = None
  TARGET_CMAKE_TOOLCHAIN_FILE = None
  CMAKE_TOOLCHAIN_FILE = None
  CMAKE_GENERATOR_x86_64-pc-windows-msvc = None
  CMAKE_GENERATOR_x86_64_pc_windows_msvc = None
  TARGET_CMAKE_GENERATOR = None
  CMAKE_GENERATOR = None
  CMAKE_PREFIX_PATH_x86_64-pc-windows-msvc = None
  CMAKE_PREFIX_PATH_x86_64_pc_windows_msvc = None
  TARGET_CMAKE_PREFIX_PATH = None
  CMAKE_PREFIX_PATH = None
  CMAKE_x86_64-pc-windows-msvc = None
  CMAKE_x86_64_pc_windows_msvc = None
  TARGET_CMAKE = None
  CMAKE = None

  --- stderr

  thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:955:25:
  not windows
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The first step seems to be to set the CMAKE_GENERATOR env var to something from https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2016%202019.html (in the future, this will have to be kept in sync with the --manifest-version for xwin).

But to do that, I'll first have to merge #153, which contains a major rework of the Dockerfile

Building NNG fails because the `cc` and `cmake` crates cannot properly detect MSVC cross-platform builds by themselves. ``` error: failed to run custom build command for `nng-sys v1.4.0-rc.0` Caused by: process didn't exit successfully: `/tmp/build/80754af9/repo/target/release/build/nng-sys-2712530b7f2d6bdf/build-script-build` (exit status: 101) --- stdout cargo:rustc-cfg=try_from CMAKE_TOOLCHAIN_FILE_x86_64-pc-windows-msvc = None CMAKE_TOOLCHAIN_FILE_x86_64_pc_windows_msvc = None TARGET_CMAKE_TOOLCHAIN_FILE = None CMAKE_TOOLCHAIN_FILE = None CMAKE_GENERATOR_x86_64-pc-windows-msvc = None CMAKE_GENERATOR_x86_64_pc_windows_msvc = None TARGET_CMAKE_GENERATOR = None CMAKE_GENERATOR = None CMAKE_PREFIX_PATH_x86_64-pc-windows-msvc = None CMAKE_PREFIX_PATH_x86_64_pc_windows_msvc = None TARGET_CMAKE_PREFIX_PATH = None CMAKE_PREFIX_PATH = None CMAKE_x86_64-pc-windows-msvc = None CMAKE_x86_64_pc_windows_msvc = None TARGET_CMAKE = None CMAKE = None --- stderr thread 'main' panicked at /usr/local/cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:955:25: not windows note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` The first step seems to be to set the `CMAKE_GENERATOR` env var to something from https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2016%202019.html (in the future, this will have to be kept in sync with the `--manifest-version` for xwin). But to do that, I'll first have to merge #153, which contains a major rework of the Dockerfile
lucas commented 2023-11-28 23:41:01 +01:00
Author
Owner
Copy link

The nng-sys crate itself seems to have feature flags for the various CMake generators: https://github.com/alexkornitzer/nng-sys#features

So I might only have to figure out how to enable feature flags conditionally by target/profile.

The `nng-sys` crate itself seems to have feature flags for the various CMake generators: https://github.com/alexkornitzer/nng-sys#features So I might only have to figure out how to enable feature flags conditionally by target/profile.
lucas force-pushed feat/nexus-uri-handler from ae616d380a
Some checks failed
lint/clippy Checking for common mistakes and opportunities for code improvement
build/linux Build for the target platform: linux
build/msvc Build for the target platform: msvc
to c4cc58898b
All checks were successful
lint/clippy Checking for common mistakes and opportunities for code improvement
build/msvc Build for the target platform: msvc
build/linux Build for the target platform: linux
2023-11-29 14:26:39 +01:00 Compare
lucas force-pushed feat/nexus-uri-handler from c4cc58898b
All checks were successful
lint/clippy Checking for common mistakes and opportunities for code improvement
build/msvc Build for the target platform: msvc
build/linux Build for the target platform: linux
to 4c6ad1aaed
All checks were successful
lint/clippy Checking for common mistakes and opportunities for code improvement
build/msvc Build for the target platform: msvc
build/linux Build for the target platform: linux
2023-11-30 18:12:57 +01:00 Compare
lucas commented 2023-12-01 09:22:02 +01:00
Author
Owner
Copy link

I wasn't able to set up cross-compilation for nng/nng-sys, so instead I went for interprocess + bincode, which don't need any external libraries.

I wasn't able to set up cross-compilation for `nng`/`nng-sys`, so instead I went for `interprocess` + `bincode`, which don't need any external libraries.
lucas merged commit 52959a3d5d into master 2023-12-01 09:22:09 +01:00
lucas deleted branch feat/nexus-uri-handler 2023-12-01 09:22:09 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
ci

   
crate/dtmm

   
crate/dtmt

   
crate/sdk

   
crate/serde_sjson
  
kind
bug
Something is not working

  
kind
documentation
Documentation needs to be adjusted

  
kind
enhancement
Improvement of existing functionality

  
kind
feature
New behaviour or functionality

  
kind
question
User is asking a question

  
kind
upstream
Root cause can be found in a dependency

  
part/bundle

   
part/filetype
  
stage
actionable

  
stage
design

  
stage
proposal

  
status/duplicate

This issue or pull request already exists

  
status/good first issue

Simple and/or isolated changes that can serve as an introduction to the code base

  
status/help wanted

   
status/invalid

Something is wrong

  
status
need-replicate
Additional information required to replicate the issue for debuggin

  
status/wontfix

This won't be fixed

No labels
ci
crate/dtmm
crate/dtmt
crate/sdk
crate/serde_sjson
kind
bug
kind
documentation
kind
enhancement
kind
feature
kind
question
kind
upstream
part/bundle
part/filetype
stage
actionable
stage
design
stage
proposal
status/duplicate
status/good first issue
status/help wanted
status/invalid
status
need-replicate
status/wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Depends on
#147 Fetch file version from Nexus
bitsquid_dt/dtmt
#153 Improve CI
bitsquid_dt/dtmt
Reference
bitsquid_dt/dtmt!150
No description provided.