Ensure binary data is read to end #36

New issue

Open

opened 2023-02-25 13:56:48 +01:00 by lucas · 0 comments

lucas commented

2023-02-25 13:56:48 +01:00

Owner

#28 (comment) (link to one comment) was caused by missing a single byte value in the binary format of .package files.
To avoid things like that in the future, it would be helpful to have a way to ensure that whenever binary data of a fixed size (e.g. for a file type) is read, there is a final check that the end has been reached.

It doesn't prevent reading of partially known data, as you can just seek deliberately. But it does prevent accidentally not reading parts of it, and end up in the same situation as above.

https://git.sclu1034.dev/bitsquid_dt/dtmt/issues/28#issuecomment-544 (link to one comment) was caused by missing a single byte value in the binary format of `.package` files. To avoid things like that in the future, it would be helpful to have a way to ensure that whenever binary data of a fixed size (e.g. for a file type) is read, there is a final check that the end has been reached. It doesn't prevent reading of partially known data, as you can just seek deliberately. But it does prevent accidentally not reading parts of it, and end up in the same situation as above.