fix(web): stop tool card crashes from taking down the session view #54

Merged

lucas merged 2 commits from 53-ask-tool-card-crashes-the-session-view-on-options-without-a-label into main

2026-10-21 16:58:18 +02:00

omp-deck commented

2026-10-21 16:55:30 +02:00

Collaborator

An ask call whose arguments were still streaming, or arrived with options that weren't { label: string } objects, crashed AskTool on label.endsWith. With no error boundary around tool renderers, that one card replaced the whole session route with the router's error page. This PR makes the ask card tolerate malformed arguments and wraps every tool card body in its own error boundary.

Decisions

Rebased onto origin/main after the branch was first cut from a stale local main; upstream touched none of the changed files (comment).
The boundary's resetKey is stream ?? args. Both are replaced on every streaming update, so a crashed card retries as soon as more data arrives (comment).

Verification

Throwaway bun test that ran renderToString(<AskTool>) with options [{}, "Plain", { label: "A (Recommended)" }], a null question and a selection containing undefined rendered without throwing: it showed Plain (selected) and A (Recommended), and dropped {}. The test was removed afterwards.
bun run typecheck in apps/web passed, both before and after the rebase.
Not exercised: the boundary's fallback in a live browser. Server-side rendering does not run error boundaries, so a throwing renderer was not tested.

Closes #53

An `ask` call whose arguments were still streaming, or arrived with options that weren't `{ label: string }` objects, crashed `AskTool` on `label.endsWith`. With no error boundary around tool renderers, that one card replaced the whole session route with the router's error page. This PR makes the ask card tolerate malformed arguments and wraps every tool card body in its own error boundary. ## Decisions - Rebased onto `origin/main` after the branch was first cut from a stale local `main`; upstream touched none of the changed files ([comment](https://git.sclu1034.dev/lucas/omp-deck/issues/53#issuecomment-16525)). - The boundary's `resetKey` is `stream ?? args`. Both are replaced on every streaming update, so a crashed card retries as soon as more data arrives ([comment](https://git.sclu1034.dev/lucas/omp-deck/issues/53#issuecomment-16525)). ## Verification - Throwaway `bun test` that ran `renderToString(<AskTool>)` with options `[{}, "Plain", { label: "A (Recommended)" }]`, a `null` question and a selection containing `undefined` rendered without throwing: it showed `Plain` (selected) and `A (Recommended)`, and dropped `{}`. The test was removed afterwards. - `bun run typecheck` in `apps/web` passed, both before and after the rebase. - Not exercised: the boundary's fallback in a live browser. Server-side rendering does not run error boundaries, so a throwing renderer was not tested. Closes #53

omp-deck added 2 commits

2026-10-21 16:55:31 +02:00

fix(web): stop the ask card crashing on malformed options f97ac015d7

While an ask call streams, its arguments are partial JSON, so an option
can arrive as `{}` or as a plain string. The card assumed every option
had a string label and threw on `endsWith`, taking the session route
down. Options without a label are now skipped, plain-string options are
accepted, and non-string selections in the result are ignored.

Co-Authored-By: Claude Opus 5.5 via omp-deck

fix(web): contain tool renderer crashes to their own card 5f8bac1c84

A throwing tool renderer used to unmount the whole session route into
the router's error page. Each card body now has its own error boundary
that shows the error inline and retries once the call's args or stream
change.

Co-Authored-By: Claude Opus 5.5 via omp-deck

omp-deck referenced this pull request

2026-10-21 16:55:46 +02:00

Ask tool card crashes the session view on options without a label #53