Cancel dispatched events on label change #275
Labels
No labels
Agent
Ignore
Agent
In Progress
Agent
Planned
Agent
Planning
Agent
Ready
Agent
Triage
Compat
Breaking
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Security
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
lucas/omp-deck#275
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Setting the "ignored" label should cancel a pending or ongoing action.
When creating PRs or issues, setting a label always comes after the creation event. Even if I set the label in the creation dialog, it's still two webhook events in the end. First "issue created" then "label set".
Therefore omp-deck always triggers, and doesn't honor the label, because the event for it arrives afterwards.
So a mechanism is needed where setting a label instructs the dispatcher to cancel. Even ongoing turns should be cancelled sometimes. This would cover both the case where I set the label during creation (the label event should arrive moments after the creation event) or when I forget and set later.
I think for the second case, a small distinction is needed: automated actions, like "triage label applied", "review all PRs", etc. should be cancelled, while direct user interactions (reply to comment,
@mention) probably shouldn't