Improve error dialogs #62

New issue

Closed

opened 2023-03-09 11:25:22 +01:00 by lucas · 1 comment

lucas commented

2023-03-09 11:25:22 +01:00

Owner

Fork color_eyre to expose more of its Handler's internal details, such as sections. Then I can use those to compose a custom representation of the error in the dialogs, rather than the default debug print.

Fork `color_eyre` to expose more of its `Handler`'s internal details, such as `sections`. Then I can use those to compose a custom representation of the error in the dialogs, rather than the default debug print.

lucas added the

labels 2023-03-09 11:25:22 +01:00

lucas added this to the Mod Manager project 2023-03-09 11:25:22 +01:00

lucas commented

2023-03-28 09:22:46 +02:00

Author

Owner

While the full error chain is quite helpful to track an error in code, for user errors, only the root cause is generally helpful.

So the error dialogs should probably only display the top-most error, since that usually describes the operation that the user wanted to perform, and the bottom-most one, as that is where it actually failed.
For additional context, I might also want to provide the entry right above the root cause. E.g. when it's an IO error, I usually add the path as context above that.

Potential template:

Failed to deploy mods!

Failed to write deployment data to 'path/to/deployment': No such file or directory

Suggestion: Make sure the 'Game Directory' setting is correct.

While the full error chain is quite helpful to track an error in code, for user errors, only the root cause is generally helpful. So the error dialogs should probably only display the top-most error, since that usually describes the operation that the user wanted to perform, and the bottom-most one, as that is where it actually failed. For additional context, I might also want to provide the entry right above the root cause. E.g. when it's an IO error, I usually add the path as context above that. Potential template: --- #### Failed to deploy mods! Failed to write deployment data to 'path/to/deployment': No such file or directory **Suggestion:** Make sure the 'Game Directory' setting is correct. ---

lucas referenced this issue from a commit

2023-03-28 14:48:11 +02:00

feat(dtmm): Improve error dialog visuals

lucas referenced this issue from a pull request that will close it,

2023-03-28 14:48:23 +02:00

Improve error dialog visuals #91

lucas closed this issue

2023-03-28 20:50:16 +02:00