fix(deps): update rust crate url to v2.5.4

Merge pull request 'Miscellaneous changes' (#239 ) from feat/ci into master
Reviewed-on: #239
2025-04-21 21:46:13 +00:00 · 2025-04-21 23:34:39 +02:00 · 2025-04-21 23:15:08 +02:00 · 2025-04-21 23:13:36 +02:00 · 2025-04-21 22:52:54 +02:00 · 2025-04-21 18:45:18 +02:00
14 changed files with 296 additions and 85 deletions
--- a/.ci/tasks/build.sh
+++ b/.ci/tasks/build.sh
@ -24,7 +24,7 @@ PR=${PR:-}
 if [ -n "$PR" ]; then
    title "PR: $(echo "$PR" | jq '.number') - $(echo "$PR" | jq '.title')"
    ref="pr-$(echo "$PR" | jq '.number')-$(git rev-parse --short "$(cat .git/ref || echo "HEAD")" 2>/dev/null || echo 'manual')"
-elif [ -f ".git/branch"]; then
+elif [ -f ".git/branch" ]; then
    ref=$(cat .git/branch)-$(git rev-parse --short $ref)
 else
    ref=$(git rev-parse --short "$(cat .git/ref || echo "HEAD")")
--- a/.ci/tasks/clippy.sh
+++ b/.ci/tasks/clippy.sh
@ -10,6 +10,6 @@ title "Install clippy"
 rustup component add clippy

 title "Run clippy"
-cargo clippy --color always --no-deps
+cargo clippy --color always --no-deps -- -D warnings

 title "Done"
--- a/.gitmodules
+++ b/.gitmodules
@ -1,6 +1,3 @@
-[submodule "lib/serde_sjson"]
-	path = lib/serde_sjson
-	url = https://git.sclu1034.dev/lucas/serde_sjson.git
 [submodule "lib/luajit2-sys"]
 	path = lib/luajit2-sys
 	url = https://github.com/sclu1034/luajit2-sys.git
--- a/Cargo.lock
+++ b/Cargo.lock
@ -39,7 +39,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "c43e7fd8284f025d0bd143c2855618ecdf697db55bde39211e5c9faec7669173"
 dependencies = [
 "heapless",
- "nom",
+ "nom 7.1.3",
 ]

 [[package]]
@ -383,7 +383,7 @@ version = "0.6.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "6fac387a98bb7c37292057cffc56d62ecb629900026402633ae9160df93a8766"
 dependencies = [
- "nom",
+ "nom 7.1.3",
 ]

 [[package]]
@ -1755,13 +1755,142 @@ dependencies = [
 ]

 [[package]]
-name = "idna"
-version = "0.5.0"
+name = "icu_collections"
+version = "1.5.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "634d9b1461af396cad843f47fdba5597a4f9e6ddd4bfb6ff5d85028c25cb12f6"
+checksum = "db2fa452206ebee18c4b5c2274dbf1de17008e874b4dc4f0aea9d01ca79e4526"
 dependencies = [
- "unicode-bidi",
- "unicode-normalization",
+ "displaydoc",
+ "yoke",
+ "zerofrom",
+ "zerovec",
+]
+
+[[package]]
+name = "icu_locid"
+version = "1.5.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "13acbb8371917fc971be86fc8057c41a64b521c184808a698c02acc242dbf637"
+dependencies = [
+ "displaydoc",
+ "litemap",
+ "tinystr",
+ "writeable",
+ "zerovec",
+]
+
+[[package]]
+name = "icu_locid_transform"
+version = "1.5.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "01d11ac35de8e40fdeda00d9e1e9d92525f3f9d887cdd7aa81d727596788b54e"
+dependencies = [
+ "displaydoc",
+ "icu_locid",
+ "icu_locid_transform_data",
+ "icu_provider",
+ "tinystr",
+ "zerovec",
+]
+
+[[package]]
+name = "icu_locid_transform_data"
+version = "1.5.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "7515e6d781098bf9f7205ab3fc7e9709d34554ae0b21ddbcb5febfa4bc7df11d"
+
+[[package]]
+name = "icu_normalizer"
+version = "1.5.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "19ce3e0da2ec68599d193c93d088142efd7f9c5d6fc9b803774855747dc6a84f"
+dependencies = [
+ "displaydoc",
+ "icu_collections",
+ "icu_normalizer_data",
+ "icu_properties",
+ "icu_provider",
+ "smallvec",
+ "utf16_iter",
+ "utf8_iter",
+ "write16",
+ "zerovec",
+]
+
+[[package]]
+name = "icu_normalizer_data"
+version = "1.5.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c5e8338228bdc8ab83303f16b797e177953730f601a96c25d10cb3ab0daa0cb7"
+
+[[package]]
+name = "icu_properties"
+version = "1.5.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "93d6020766cfc6302c15dbbc9c8778c37e62c14427cb7f6e601d849e092aeef5"
+dependencies = [
+ "displaydoc",
+ "icu_collections",
+ "icu_locid_transform",
+ "icu_properties_data",
+ "icu_provider",
+ "tinystr",
+ "zerovec",
+]
+
+[[package]]
+name = "icu_properties_data"
+version = "1.5.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "85fb8799753b75aee8d2a21d7c14d9f38921b54b3dbda10f5a3c7a7b82dba5e2"
+
+[[package]]
+name = "icu_provider"
+version = "1.5.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "6ed421c8a8ef78d3e2dbc98a973be2f3770cb42b606e3ab18d6237c4dfde68d9"
+dependencies = [
+ "displaydoc",
+ "icu_locid",
+ "icu_provider_macros",
+ "stable_deref_trait",
+ "tinystr",
+ "writeable",
+ "yoke",
+ "zerofrom",
+ "zerovec",
+]
+
+[[package]]
+name = "icu_provider_macros"
+version = "1.5.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1ec89e9337638ecdc08744df490b221a7399bf8d164eb52a665454e60e075ad6"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn 2.0.90",
+]
+
+[[package]]
+name = "idna"
+version = "1.0.3"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "686f825264d630750a544639377bae737628043f20d38bbc029e8f29ea968a7e"
+dependencies = [
+ "idna_adapter",
+ "smallvec",
+ "utf8_iter",
+]
+
+[[package]]
+name = "idna_adapter"
+version = "1.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "daca1df1c957320b2cf139ac61e7bd64fed304c5040df000a745aa1de3b4ef71"
+dependencies = [
+ "icu_normalizer",
+ "icu_properties",
 ]

 [[package]]
@ -2033,7 +2162,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "4979f22fdb869068da03c9f7528f8297c6fd2606bc3a4affe42e6a823fdb8da4"
 dependencies = [
 "cfg-if",
- "windows-targets 0.48.5",
+ "windows-targets 0.52.6",
 ]

 [[package]]
@ -2059,6 +2188,12 @@ version = "0.9.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "cd945864f07fe9f5371a27ad7b52a172b4b499999f1d97574c9fa68373937e12"

+[[package]]
+name = "litemap"
+version = "0.7.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "23fb14cb19457329c82206317a5663005a4d404783dc74f4252769b0d5f42856"
+
 [[package]]
 name = "lockfree-object-pool"
 version = "0.1.6"
@ -2274,14 +2409,23 @@ dependencies = [
 ]

 [[package]]
-name = "nom_locate"
-version = "4.2.0"
+name = "nom"
+version = "8.0.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1e3c83c053b0713da60c5b8de47fe8e494fe3ece5267b2f23090a07a053ba8f3"
+checksum = "df9761775871bdef83bee530e60050f7e54b1105350d6884eb0fb4f46c2f9405"
+dependencies = [
+ "memchr",
+]
+
+[[package]]
+name = "nom_locate"
+version = "5.0.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "0b577e2d69827c4740cba2b52efaad1c4cc7c73042860b199710b3575c68438d"
 dependencies = [
 "bytecount",
 "memchr",
- "nom",
+ "nom 8.0.0",
 ]

 [[package]]
@ -3036,7 +3180,7 @@ version = "1.0.5"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "d97817398dd4bb2e6da002002db259209759911da105da92bec29ccb12cf58bf"
 dependencies = [
- "bitflags 2.7.0",
+ "bitflags 2.9.0",
 "errno",
 "libc",
 "linux-raw-sys 0.9.4",
@ -3269,9 +3413,11 @@ dependencies = [

 [[package]]
 name = "serde_sjson"
-version = "1.0.0"
+version = "1.2.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1c5b0d7af37492e99b8559436ee76b9ec8935c75449b1c2ef08c205a9e92ae6f"
 dependencies = [
- "nom",
+ "nom 8.0.0",
 "nom_locate",
 "serde",
 ]
@ -3500,6 +3646,17 @@ dependencies = [
 "futures-core",
 ]

+[[package]]
+name = "synstructure"
+version = "0.13.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c8af7666ab7b6390ab78131fb5b0fce11d6b7a6951602017c35fa82800708971"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn 2.0.90",
+]
+
 [[package]]
 name = "system-configuration"
 version = "0.6.0"
@ -3677,23 +3834,9 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "9117f5d4db391c1cf6927e7bea3db74b9a1c1add8f7eda9ffd5364f40f57b82f"
 dependencies = [
 "displaydoc",
+ "zerovec",
 ]

-[[package]]
-name = "tinyvec"
-version = "1.8.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "445e881f4f6d382d5f27c034e25eb92edd7c784ceab92a0937db7f2e9471b938"
-dependencies = [
- "tinyvec_macros",
-]
-
-[[package]]
-name = "tinyvec_macros"
-version = "0.1.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1f3ccbac311fea05f86f61904b462b55fb3df8837a366dfc601a0161d0532f20"
-
 [[package]]
 name = "tokio"
 version = "1.44.2"
@ -4072,15 +4215,6 @@ version = "1.0.12"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "3354b9ac3fae1ff6755cb6db53683adb661634f67557942dea4facebec0fee4b"

-[[package]]
-name = "unicode-normalization"
-version = "0.1.23"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a56d1686db2308d901306f92a263857ef59ea39678a5458e7cb17f01415101f5"
-dependencies = [
- "tinyvec",
-]
-
 [[package]]
 name = "unicode-script"
 version = "0.5.6"
@ -4119,9 +4253,9 @@ checksum = "8ecb6da28b8a351d773b68d5825ac39017e680750f980f3a1a85cd8dd28a47c1"

 [[package]]
 name = "url"
-version = "2.5.2"
+version = "2.5.4"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "22784dbdf76fdde8af1aeda5622b546b422b6fc585325248a2bf9f5e41e94d6c"
+checksum = "32f8b686cadd1473f4bd0117a5d28d36b1ade384ea9b5069a1c40aefed7fda60"
 dependencies = [
 "form_urlencoded",
 "idna",
@ -4155,12 +4289,24 @@ dependencies = [
 "xmlwriter",
 ]

+[[package]]
+name = "utf16_iter"
+version = "1.0.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "c8232dd3cdaed5356e0f716d285e4b40b932ac434100fe9b7e0e8e935b9e6246"
+
 [[package]]
 name = "utf16_lit"
 version = "2.0.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "14706d2a800ee8ff38c1d3edb873cd616971ea59eb7c0d046bb44ef59b06a1ae"

+[[package]]
+name = "utf8_iter"
+version = "1.0.4"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "b6c140620e7ffbb22c2dee59cafe6084a59b5ffc27a8859a5f0d494b5d52b6be"
+
 [[package]]
 name = "utf8parse"
 version = "0.2.2"
@ -4374,7 +4520,7 @@ version = "0.1.9"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "cf221c93e13a30d793f7645a0e7762c55d169dbb0a49671918a2319d289b10bb"
 dependencies = [
- "windows-sys 0.48.0",
+ "windows-sys 0.59.0",
 ]

 [[package]]
@ -4682,9 +4828,21 @@ version = "0.39.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "6f42320e61fe2cfd34354ecb597f86f413484a798ba44a8ca1165c58d42da6c1"
 dependencies = [
- "bitflags 2.7.0",
+ "bitflags 2.9.0",
 ]

+[[package]]
+name = "write16"
+version = "1.0.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "d1890f4022759daae28ed4fe62859b1236caebfc61ede2f63ed4e695f3f6d936"
+
+[[package]]
+name = "writeable"
+version = "0.5.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1e9df38ee2d2c3c5948ea468a8406ff0db0b29ae1ffde1bcf20ef305bcc95c51"
+
 [[package]]
 name = "xi-unicode"
 version = "0.3.0"
@ -4709,12 +4867,79 @@ version = "0.5.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "09041cd90cf85f7f8b2df60c646f853b7f535ce68f85244eb6731cf89fa498ec"

+[[package]]
+name = "yoke"
+version = "0.7.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "120e6aef9aa629e3d4f52dc8cc43a015c7724194c97dfaf45180d2daf2b77f40"
+dependencies = [
+ "serde",
+ "stable_deref_trait",
+ "yoke-derive",
+ "zerofrom",
+]
+
+[[package]]
+name = "yoke-derive"
+version = "0.7.5"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "2380878cad4ac9aac1e2435f3eb4020e8374b5f13c296cb75b4620ff8e229154"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn 2.0.90",
+ "synstructure",
+]
+
+[[package]]
+name = "zerofrom"
+version = "0.1.6"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "50cc42e0333e05660c3587f3bf9d0478688e15d870fab3346451ce7f8c9fbea5"
+dependencies = [
+ "zerofrom-derive",
+]
+
+[[package]]
+name = "zerofrom-derive"
+version = "0.1.6"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "d71e5d6e06ab090c67b5e44993ec16b72dcbaabc526db883a360057678b48502"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn 2.0.90",
+ "synstructure",
+]
+
 [[package]]
 name = "zeroize"
 version = "1.8.1"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "ced3678a2879b30306d323f4542626697a464a97c0a07c9aebf7ebca65cd4dde"

+[[package]]
+name = "zerovec"
+version = "0.10.4"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "aa2b893d79df23bfb12d5461018d408ea19dfafe76c2c7ef6d4eba614f8ff079"
+dependencies = [
+ "yoke",
+ "zerofrom",
+ "zerovec-derive",
+]
+
+[[package]]
+name = "zerovec-derive"
+version = "0.10.3"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "6eafa6dfb17584ea3e2bd6e76e0cc15ad7af12b09abdd1ca55961bed9b1063c6"
+dependencies = [
+ "proc-macro2",
+ "quote",
+ "syn 2.0.90",
+]
+
 [[package]]
 name = "zip"
 version = "2.6.1"
--- a/Cargo.toml
+++ b/Cargo.toml
@ -6,7 +6,6 @@ members = [
    "lib/dtmt-shared",
    "lib/oodle",
    "lib/sdk",
-    "lib/serde_sjson",
    "lib/luajit2-sys",
    "lib/color-eyre",
 ]
@ -35,7 +34,7 @@ glob = "0.3.0"
 interprocess = "2.1.0"
 lazy_static = "1.4.0"
 luajit2-sys = { path = "lib/luajit2-sys" }
-minijinja = { version = "2.0.1", default-features = false }
+minijinja = { version = "2.0.1", default-features = false, features = ["serde"] }
 nanorand = "0.7.0"
 nexusmods = { path = "lib/nexusmods" }
 notify = "8.0.0"
@ -47,7 +46,7 @@ pin-project-lite = "0.2.9"
 promptly = "0.3.1"
 sdk = { path = "lib/sdk" }
 serde = { version = "1.0.152", features = ["derive", "rc"] }
-serde_sjson = { path = "lib/serde_sjson" }
+serde_sjson = "1.2.1"
 steamlocate = "2.0.0-beta.2"
 strip-ansi-escapes = "0.2.0"
 time = { version = "0.3.20", features = ["serde", "serde-well-known", "local-offset", "formatting", "macros"] }
--- a/crates/dtmm/src/controller/deploy.rs
+++ b/crates/dtmm/src/controller/deploy.rs
@ -116,14 +116,14 @@ async fn patch_game_settings(state: Arc<ActionState>) -> Result<()> {
        eyre::bail!("couldn't find 'boot_script' field");
    };

-    f.write_all(settings[0..i].as_bytes()).await?;
+    f.write_all(&settings.as_bytes()[0..i]).await?;
    f.write_all(b"boot_script = \"scripts/mod_main\"").await?;

    let Some(j) = settings[i..].find('\n') else {
        eyre::bail!("couldn't find end of 'boot_script' field");
    };

-    f.write_all(settings[(i + j)..].as_bytes()).await?;
+    f.write_all(&settings.as_bytes()[(i + j)..]).await?;

    Ok(())
 }
@ -453,10 +453,7 @@ async fn build_bundles(state: Arc<ActionState>) -> Result<Vec<Bundle>> {
 }

 #[tracing::instrument(skip_all)]
-async fn patch_boot_bundle(
-    state: Arc<ActionState>,
-    deployment_info: &String,
-) -> Result<Vec<Bundle>> {
+async fn patch_boot_bundle(state: Arc<ActionState>, deployment_info: &str) -> Result<Vec<Bundle>> {
    let bundle_dir = Arc::new(state.game_dir.join("bundle"));
    let bundle_path = bundle_dir.join(format!("{:x}", Murmur64::hash(BOOT_BUNDLE_NAME.as_bytes())));

@ -590,11 +587,7 @@ fn build_deployment_data(
            .map(|bundle| format!("{:x}", bundle.name().to_murmur64()))
            .collect(),
        // TODO:
-        mod_folders: mod_folders
-            .as_ref()
-            .iter()
-            .map(|folder| folder.clone())
-            .collect(),
+        mod_folders: mod_folders.as_ref().to_vec(),
    };
    serde_sjson::to_string(&info).wrap_err("Failed to serizalize deployment data")
 }
--- a/crates/dtmm/src/controller/game.rs
+++ b/crates/dtmm/src/controller/game.rs
@ -91,14 +91,14 @@ async fn patch_game_settings(state: Arc<ActionState>) -> Result<()> {
        eyre::bail!("couldn't find 'boot_script' field");
    };

-    f.write_all(settings[0..i].as_bytes()).await?;
+    f.write_all(&settings.as_bytes()[0..i]).await?;
    f.write_all(b"boot_script = \"scripts/mod_main\"").await?;

    let Some(j) = settings[i..].find('\n') else {
        eyre::bail!("couldn't find end of 'boot_script' field");
    };

-    f.write_all(settings[(i + j)..].as_bytes()).await?;
+    f.write_all(&settings.as_bytes()[(i + j)..]).await?;

    Ok(())
 }
@ -208,7 +208,7 @@ pub(crate) async fn reset_mod_deployment(state: ActionState) -> Result<()> {

    for p in paths {
        let path = bundle_dir.join(p);
-        let backup = bundle_dir.join(&format!("{}.bak", p));
+        let backup = bundle_dir.join(format!("{}.bak", p));

        let res = async {
            tracing::debug!(
--- a/crates/dtmm/src/controller/import.rs
+++ b/crates/dtmm/src/controller/import.rs
@ -397,7 +397,7 @@ fn extract_legacy_mod<R: Read + Seek>(
            tracing::trace!("Writing file '{}'", name.display());
            let mut out = std::fs::OpenOptions::new()
                .write(true)
-                .create(true)
+                .truncate(true)
                .open(&name)
                .wrap_err_with(|| format!("Failed to open file '{}'", name.display()))?;

--- a/crates/dtmt/src/cmd/bundle/extract.rs
+++ b/crates/dtmt/src/cmd/bundle/extract.rs
@ -150,7 +150,7 @@ async fn parse_command_line_template(tmpl: &String) -> Result<CmdLine> {
            String::from_utf8_unchecked(bytes.to_vec())
        });

-        while let Some(arg) = parsed.next() {
+        for arg in parsed.by_ref() {
            // Safety: See above.
            cmd.arg(unsafe { String::from_utf8_unchecked(arg.to_vec()) });
        }
--- a/crates/dtmt/src/shell_parse.rs
+++ b/crates/dtmt/src/shell_parse.rs
@ -54,17 +54,11 @@ impl<'a> ShellParser<'a> {
                    }
                    _ => {}
                },
-                ParserState::SingleQuote => match c {
-                    b'\'' => {
-                        return Some(&self.bytes[start..(self.offset - 1)]);
-                    }
-                    _ => {}
+                ParserState::SingleQuote => if c == b'\'' {
+                    return Some(&self.bytes[start..(self.offset - 1)]);
                },
-                ParserState::DoubleQuote => match c {
-                    b'"' => {
-                        return Some(&self.bytes[start..(self.offset - 1)]);
-                    }
-                    _ => {}
+                ParserState::DoubleQuote => if c == b'"' {
+                    return Some(&self.bytes[start..(self.offset - 1)]);
                },
            }
        }
--- a/lib/sdk/src/bundle/mod.rs
+++ b/lib/sdk/src/bundle/mod.rs
@ -237,7 +237,7 @@ impl Bundle {

        // Ceiling division (or division toward infinity) to calculate
        // the number of chunks required to fit the unpacked data.
-        let num_chunks = (unpacked_data.len() + CHUNK_SIZE - 1) / CHUNK_SIZE;
+        let num_chunks = unpacked_data.len().div_ceil(CHUNK_SIZE);
        tracing::trace!(num_chunks);
        w.write_u32(num_chunks as u32)?;

--- a/lib/sdk/src/filetype/lua.rs
+++ b/lib/sdk/src/filetype/lua.rs
@ -125,7 +125,7 @@ pub fn compile(name: impl Into<IdString64>, code: impl AsRef<str>) -> Result<Bun
    tracing::trace!(
        "Compiling '{}', {} bytes of code",
        name.display(),
-        code.as_bytes().len()
+        code.len()
    );

    let bytecode = unsafe {
@ -156,10 +156,10 @@ pub fn compile(name: impl Into<IdString64>, code: impl AsRef<str>) -> Result<Bun
            }
            _ => unreachable!(),
        }
-        lua::lua_setglobal(state, b"fn\0".as_ptr() as _);
+        lua::lua_setglobal(state, c"fn".as_ptr());

-        let run = b"return string.dump(fn, false)\0";
-        match lua::luaL_loadstring(state, run.as_ptr() as _) as u32 {
+        let run = c"return string.dump(fn, false)";
+        match lua::luaL_loadstring(state, run.as_ptr()) as u32 {
            lua::LUA_OK => {}
            lua::LUA_ERRSYNTAX => {
                let err = lua::lua_tostring(state, -1);
--- a/lib/sdk/src/filetype/strings.rs
+++ b/lib/sdk/src/filetype/strings.rs
@ -28,10 +28,14 @@ impl Language {
 #[derive(serde::Serialize)]
 pub struct Strings(HashMap<String, HashMap<Language, String>>);

+#[inline(always)]
 fn read_string<R>(r: R) -> Result<String>
 where
    R: Read,
 {
+    // We can safely ignore the warning here, as all data is already in memory, and no additional
+    // `BufReader` should be needed.
+    #[allow(clippy::unbuffered_bytes)]
    r.bytes()
        .take_while(|b| b.as_ref().map(|b| *b != 0).unwrap_or(false))
        .map(|b| b.map_err(Report::new))
@ -41,7 +45,7 @@ where

 impl Strings {
    #[tracing::instrument(skip_all, fields(languages = variants.len()))]
-    pub fn from_variants(ctx: &crate::Context, variants: &Vec<BundleFileVariant>) -> Result<Self> {
+    pub fn from_variants(ctx: &crate::Context, variants: &[BundleFileVariant]) -> Result<Self> {
        let mut map: HashMap<String, HashMap<Language, String>> = HashMap::new();

        for (i, variant) in variants.iter().enumerate() {
@ -76,7 +80,7 @@ impl Strings {
 }

 #[tracing::instrument(skip_all)]
-pub fn decompile(ctx: &crate::Context, variants: &Vec<BundleFileVariant>) -> Result<Vec<UserFile>> {
+pub fn decompile(ctx: &crate::Context, variants: &[BundleFileVariant]) -> Result<Vec<UserFile>> {
    let strings = Strings::from_variants(ctx, variants)?;
    let content = strings.to_sjson()?;

--- a/lib/serde_sjson
+++ b/lib/serde_sjson
@ -1 +0,0 @@
-Subproject commit 73d2b23ce50e75b184f5092ad515e97a0adbe6da
Author	SHA1	Message	Date
Renovate	6e58449dac	fix(deps): update rust crate url to v2.5.4 All checks were successful build/linux Build for the target platform: linux lint/clippy Checking for common mistakes and opportunities for code improvement build/msvc Build for the target platform: msvc	2025-04-21 21:46:13 +00:00
Lucas Schwiderski	813b927da0	Merge pull request 'Miscellaneous changes' (#239 ) from feat/ci into master Some checks failed build/msvc Build for the target platform: msvc build/linux Build for the target platform: linux Reviewed-on: #239	2025-04-21 23:34:39 +02:00
Lucas Schwiderski	bb6396c932	Fix build script All checks were successful lint/clippy Checking for common mistakes and opportunities for code improvement build/msvc Build for the target platform: msvc build/linux Build for the target platform: linux	2025-04-21 23:15:08 +02:00
Lucas Schwiderski	3d05a2395e	Fix clippy warnings	2025-04-21 23:13:36 +02:00
Lucas Schwiderski	38a023bea6	Move serde_sjson to its own project	2025-04-21 22:52:54 +02:00
Lucas Schwiderski	9ac13834a1	Commit lock file changes Seems like Renovate missed this.	2025-04-21 18:45:18 +02:00
Lucas Schwiderski	1a000371fa	Treat lint warnings as errors in CI Warnings will not show up if they don't fail CI.	2025-04-21 18:41:59 +02:00
				`@ -1 +0,0 @@`
				`Subproject commit 73d2b23ce50e75b184f5092ad515e97a0adbe6da`